Skip to content

gh-142353: Isolate tests from personal GNU Readline init files#142370

Merged
vstinner merged 3 commits intopython:mainfrom
johnslavik:isolate-from-inputrc
Dec 12, 2025
Merged

gh-142353: Isolate tests from personal GNU Readline init files#142370
vstinner merged 3 commits intopython:mainfrom
johnslavik:isolate-from-inputrc

Conversation

@johnslavik
Copy link
Member

@johnslavik johnslavik commented Dec 7, 2025 •
edited by bedevere-app bot
Loading

CC @ZeroIntensity skip news, needs backport to 3.13, needs backport to 3.14

@bedevere-app bedevere-app bot mentioned this pull request Dec 7, 2025
Closed
johnslavik
johnslavik commented Dec 7, 2025
View reviewed changes
@ZeroIntensity ZeroIntensity added tests Tests in the Lib/test dir needs backport to 3.14 bugs and security fixes skip news needs backport to 3.13 bugs and security fixes labels Dec 7, 2025
@johnslavik

This comment was marked as resolved.

Sign in to view
@johnslavik johnslavik changed the title gh-142353: Isolate tests from personal Readline init files gh-142353: Isolate tests from personal GNU Readline init files Dec 7, 2025
@johnslavik johnslavik mentioned this pull request Dec 7, 2025
Open
@picnixz picnixz dismissed a stale review December 7, 2025 23:12

spam review

vstinner
vstinner reviewed Dec 11, 2025
View reviewed changes
@johnslavik
Copy link
Member Author

johnslavik commented Dec 11, 2025 •
edited
Loading

I'll simplify this a bit, thanks for a quick review!

@johnslavik @vstinner
Remove readline logic (it is unnecessary)
1c6153a 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit f564654 into python:main Dec 12, 2025
44 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 12, 2025

Thanks @johnslavik for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 12, 2025
@johnslavik @vstinner @miss-islington
pythongh-142353: Isolate tests from personal GNU Readline init files (p…
12552f7 
…ythonGH-142370)

Isolate tests from personal Readline init files using `INPUTRC=/dev/null` trick.
(cherry picked from commit f564654)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 12, 2025
@johnslavik @vstinner @miss-islington
pythongh-142353: Isolate tests from personal GNU Readline init files (p…
537886d 
…ythonGH-142370)

Isolate tests from personal Readline init files using `INPUTRC=/dev/null` trick.
(cherry picked from commit f564654)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Dec 12, 2025

GH-142634 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 12, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 12, 2025

GH-142635 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 12, 2025
@vstinner
Copy link
Member

vstinner commented Dec 12, 2025

Merged, thanks for the fix.

vstinner added a commit that referenced this pull request Dec 12, 2025
@miss-islington @johnslavik @vstinner
[3.14] gh-142353: Isolate tests from personal GNU Readline init files (…
5e425c3 
…GH-142370) (#142634)

gh-142353: Isolate tests from personal GNU Readline init files (GH-142370)

Isolate tests from personal Readline init files using `INPUTRC=/dev/null` trick.
(cherry picked from commit f564654)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Dec 13, 2025
@miss-islington @johnslavik @vstinner
[3.13] gh-142353: Isolate tests from personal GNU Readline init files (…
e7bb732 
…GH-142370) (#142635)

gh-142353: Isolate tests from personal GNU Readline init files (GH-142370)

Isolate tests from personal Readline init files using `INPUTRC=/dev/null` trick.
(cherry picked from commit f564654)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Dec 13, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Refleaks 3.13 (tier-1) has failed when building commit e7bb732.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1484/builds/902) and take a look at the build logs.
  4. Check if the failure is related to this commit (e7bb732) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1484/builds/902

Failed tests:

  • test_httpservers

Failed subtests:

  • test_large_content_length_truncated - test.test_httpservers.CGIHTTPServerTestCase.test_large_content_length_truncated

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "b:\uildarea\3.13.ware-win11.refleak\build\Lib\test\libregrtest\single.py", line 201, in _runtest_env_changed_exc
    return
ResourceWarning: unclosed <socket.socket fd=720, family=2, type=1, proto=0, laddr=('127.0.0.1', 53869), raddr=('127.0.0.1', 53868)>


Traceback (most recent call last):
  File "b:\uildarea\3.13.ware-win11.refleak\build\Lib\test\libregrtest\single.py", line 201, in _runtest_env_changed_exc
    return
ResourceWarning: unclosed <socket.socket fd=688, family=2, type=1, proto=0, laddr=('127.0.0.1', 49650), raddr=('127.0.0.1', 49649)>


Traceback (most recent call last):
  File "b:\uildarea\3.13.ware-win11.refleak\build\Lib\test\test_httpservers.py", line 1028, in test_large_content_length_truncated
    res = self.request('/cgi-bin/file1.py', 'POST', b'x', headers)
  File "b:\uildarea\3.13.ware-win11.refleak\build\Lib\test\test_httpservers.py", line 88, in request
    self.connection.request(method, uri, body, headers)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.13.ware-win11.refleak\build\Lib\http\client.py", line 1358, in request
    self._send_request(method, url, body, headers, encode_chunked)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.13.ware-win11.refleak\build\Lib\http\client.py", line 1404, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.13.ware-win11.refleak\build\Lib\http\client.py", line 1353, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.13.ware-win11.refleak\build\Lib\http\client.py", line 1152, in _send_output
    self.send(chunk)
    ~~~~~~~~~^^^^^^^
  File "b:\uildarea\3.13.ware-win11.refleak\build\Lib\http\client.py", line 1077, in send
    self.sock.sendall(data)
    ~~~~~~~~~~~~~~~~~^^^^^^
ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnslavik @vstinner @bedevere-bot @ZeroIntensity